Check for duplicate names in gen_stub.php

[TysonAndre]

With named arguments in php 8.0, it's important that php's modules
or PECL extensions using gen_stub.php don't generate functions
with duplicate names.

Warn if a parameter name is repeated,
even if the last occurrence is a variadic parameter.
Previously, this would not be an error when compiling php-src

Related to php/php-tasks#16 and https://github.com/php/php-src/pull/6015/files

Tested by

• Running touch **/*.stub.php; make **/*_arginfo.h
• Verifying that an exception was thrown when renaming a parameter to have the same name as a previous parameter

[nikic]

I've fixed this on the PHP side in 9395e01. Do we still want to check this in stubs as well?

[nikic]

Guess it doesn't hurt.

It would be nice to refactor the error handling to catch exceptions for a particular declaration and then rethrow with a func_name(): prefix, so that these are handled consistently.

[kocsismate]

@nikic I think displaying the error as early as possible is a good thing. :)

[TysonAndre]

I think displaying the error as early as possible is a good thing. :)

Also, people may miss that if ran gen_stub.php in 8.0 and tested locally with <= 7.4 before publishing a PECL release

It would be nice to refactor the error handling to catch exceptions for a particular declaration and then rethrow with a func_name(): prefix, so that these are handled consistently.

Also,

• It would be useful to show the parameter name for missing parameter types warnings for a function
• It would be useful to show all errors for all functions before exiting with a failure status code.