Skip to content

Auto labeling #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Auto labeling #8693

merged 4 commits into from
Jun 8, 2022

Conversation

saundefined
Copy link
Member

Relates #8670 (comment).

@iluuu1994
Copy link
Member

Nice idea, thank you! Here are a couple more that could be added:

"Category: Engine":
- Zend/*

"Category: Optimizer":
- Zend/Optimizer/**/*

"Category: Build System":
- build
- scripts
- ???

SAPIs could also be added.

I'm also not sure if these need a leading /, couldn't see that at first glance from the documentation.

@saundefined
Copy link
Member Author

Thanks, added it.

I'm also not sure if these need a leading /, couldn't see that at first glance from the documentation.

It seems to be possible to use with or without a leading /.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM.

@Girgias Girgias merged commit 5f035dc into php:master Jun 8, 2022
@saundefined saundefined deleted the add-labeler branch June 8, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants