Discard known '-O' flags, including just '-O', but do not remove only '-O' in '-Ounknown' #9647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems ok, but then also several other places will need to be changed probably. Are there any compilation steps how the empty g gets entered in the C flags? |
Indeed! Thank you. I've updated these places as well I don't know enough of the build system to be able to factor this out, though |
derickr
approved these changes
May 22, 2024
arnaud-lb
added a commit
to arnaud-lb/php-src
that referenced
this pull request
Sep 10, 2024
Discard known '-O' flags, including just '-O', but do not remove only '-O' in '-Ounknown'
arnaud-lb
added a commit
that referenced
this pull request
Sep 12, 2024
Discard known '-O' flags, including just '-O', but do not remove only '-O' in '-Ounknown'
arnaud-lb
added a commit
that referenced
this pull request
Sep 12, 2024
* PHP-8.2: Do not remove -O0 in the middle of a flag Fix removal of optimization cflags in debug builds (#9647)
arnaud-lb
added a commit
that referenced
this pull request
Sep 12, 2024
* PHP-8.3: Do not remove -O0 in the middle of a flag Fix removal of optimization cflags in debug builds (#9647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9645