Enable coverage collection when enabled #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new config key 'coverage' with the following enum values: - clover - cobertura - crap4j - php - text - xml html has been left out for the moment, as it is creating a directory instead of a simple file.
discordier
force-pushed
the
feature/coverage
branch
from
6d5e616 to
89dc6d9
Compare
discordier
commented
Sep 24, 2025
| ->fromFile($this->coverageFile) | ||
| ->end(); | ||
| break; | ||
| // FIXME: this is a directory, we'll need to use a finder then or what to do? |
There was a problem hiding this comment.
@dmolineus We should discuss this. How can a plugin attach more than one file - in this case a directory - that belong together - in this case a "pages with assets".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new config key 'coverage' with the following enum values:
html has been left out for the moment, as it is creating a directory instead of a simple file.