Infer QueryBuilderType for any method returning QueryBuilder: revive with cache #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janedbal
commented
Jan 16, 2024
janedbal
commented
- Attempt to resolve Performance issues after 1.3.54 #517 by visiting each method only once.
…Builder"" This reverts commit b3e7d2d.
janedbal
commented
Jan 16, 2024
| $fileName = $methodReflection->getDeclaringClass()->getFileName(); | ||
| if ($fileName === null) { | ||
| return []; | ||
| } | ||
|
|
||
| if (isset($this->cache[$fileName][$methodName])) { | ||
| return $this->cache[$fileName][$methodName]; |
There was a problem hiding this comment.
Note: if this gets proven to help, we should improve the cache key to support multiple classes with the same method name in the same file.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.