DynamicReturnTypeExtensions: allow hooking on object #2761
Conversation
|
|
||
| public function getClass(): string | ||
| { | ||
| return 'object'; |
There was a problem hiding this comment.
Magic strings like this are a no-go :) We need a new specific extension type. I'd imagine the interface can look the same, without the getClass method.
There was a problem hiding this comment.
Ok, how do we name it?
Or how about returning null here?
There was a problem hiding this comment.
Heh, object::class works, so it is not a magic string anymore :D https://3v4l.org/rrvKH
nvm, that is nonsense
There was a problem hiding this comment.
Personally, I'd prefer null
There was a problem hiding this comment.
Implemented null version.
There was a problem hiding this comment.
The name isn't that important 😊 It can be "ClasslessDynamicMethodReturnTypeExtension".
There was a problem hiding this comment.
Classless is a good prefix! But I assume I should wait for this
|
I've got a completely different and much more universal idea how to solve this, stay tuned 😊 |
|
So I worry that we might need to add many more extensions to be able to describe universally all these situations. What I propose is a new
It would be called right at the beginning of MutatingScope::resolveType. Returning null means "I'm not interested in this expression". This mechanism would also be able to replace not-really-flexible overriding of scopeClass, because we can only have one for the whole analysis. Feel free to prototype it 😊 |
|
Added extension as requested, but I think it needs to be |
|
Closing in favor of #2789 |
To support stuff like phpstan/phpstan-doctrine#499