Skip to content

Get ggplotly() playing nicely with thematic #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2020
Merged

Get ggplotly() playing nicely with thematic #1801

merged 7 commits into from
Jun 25, 2020

Conversation

@cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jun 23, 2020 •
edited
Loading

For example

library(plotly)
thematic::thematic_on()
p <- qplot(1:10, 1:10, color = 1:10)
ggplotly(p)

Screen Shot 2020-06-23 at 12 47 15 PM

@cpsievert cpsievert requested a review from schloerke June 23, 2020 17:46
cpsievert
cpsievert commented Jun 23, 2020
View reviewed changes
@cpsievert cpsievert merged commit 1370d4f into master Jun 25, 2020
@cpsievert cpsievert deleted the autoTheme branch June 25, 2020 23:13
chschan pushed a commit to Displayr/plotly that referenced this pull request Jun 26, 2020
@pull @cpsievert
[pull] master from ropensci:master (#6)
607e377 
* Get ggplotly() playing nicely with thematic (plotly#1801)

* Pull plotly's custom ggplot_build into a function and hook into thematic if relevant

* add thematic to suggests and use it only when loaded

* update shinytest tests

* Go back to the assign() based approach

* bust cache

* CRAN version of crosstalk

* add visual tests

* update news

Co-authored-by: Carson Sievert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@schloerke schloerke schloerke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpsievert @schloerke