-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[java] Update AvoidSynchronizedAtMethodLevel message to mention ReentrantLock, new rule AvoidSynchronizedStatement #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
@chonton thanks for the PR! This looks overall very good, but the new rule If the names between rule, test and xml match as expected, they will be run automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
see https://openjdk.org/jeps/8337395
Describe the PR
Modify advice for AvoidSynchronizedAtMethodLevel and add AvoidSynchronizedStatement.
See https://openjdk.org/jeps/8337395 for detailed information about virtual thread pinning concerns.
Related issues
Ready?
./mvnw clean verify
passes (checked automatically by github actions)