Fix the issue that zero has been ignored #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielelkin
reviewed
Jul 1, 2025
| } | ||
| for (NSUInteger i = 0; i < zeros; ++i) { _operands.push_back(0.0); } | ||
|
|
||
| while ([scanner scanCharactersFromSet:[NSCharacterSet whitespaceCharacterSet] intoString:NULL]) { } |
There was a problem hiding this comment.
why is there an empty while loop here? isn't this an infinite loop
There was a problem hiding this comment.
It's not an infinite loop. It will move the scanner to next char if the current char is a whitespace.
arthurpazpicpay
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Any SVG string start with 0, has a whitespace after, and comes with dot, will make the zero being ignored.
For example, if there is a SVG string "0 0 0 .25", it will get "0" "0" "0.25", which we expect "0" "0" "0" "0.25"
Root cause
In
pathDefinitionParserwe setup the scanner to skip whitespace, which make this string "0 .25" to be recognised as "0.25"Fix
Test
Before
After
No error
