Use AudioLink band overrides even when the world provides AudioLink data #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the band override feature useful in worlds that are using AudioLink. This new behavior is more in line with the name "override" and what the docs suggest should happen when AudioLink data already exists.
Author
|
The original intent here is unclear to me. Was the original behavior of not overriding in AudioLink worlds intentional? |
slix
added a commit
to slix/PoiyomiDocs
that referenced
this pull request
Sep 2, 2025
Author
|
poiyomi/PoiyomiDocs#59 for the docs changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the band override feature useful in worlds that are using AudioLink.
This new behavior is more in line with the name "override" and what the docs suggest should happen when AudioLink data already exists.
I can clarify the documentation later if you agree with this new behavior.
Technically you could consider this a breaking change, as this changes the behavior of the shader in worlds where AudioLink is in use.