Skip to content

fix: Fix parquet decode of plain pages in dictionary column - #29001

Merged
ritchie46 merged 2 commits into
mainfrom
nxs/pq-dict
Aug 27, 2026
Merged

fix: Fix parquet decode of plain pages in dictionary column#29001
ritchie46 merged 2 commits into
mainfrom
nxs/pq-dict

Conversation

@nameexhaustion

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added A-io-parquet Area: reading/writing Parquet files fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The uncompressed lib size after this PR is 60.3488 MB.

@nameexhaustion
nameexhaustion marked this pull request as ready for review August 27, 2026 08:06
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (a6782fa) to head (b80fc63).
⚠️ Report is 99 commits behind head on main.

Files with missing lines Patch % Lines
...-parquet/src/arrow/read/deserialize/categorical.rs 86.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29001      +/-   ##
==========================================
- Coverage   81.58%   81.37%   -0.22%     
==========================================
  Files        1890     1886       -4     
  Lines      268762   267155    -1607     
  Branches     3264     3061     -203     
==========================================
- Hits       219280   217391    -1889     
- Misses      48637    48986     +349     
+ Partials      845      778      -67     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ritchie46
ritchie46 merged commit 6cadc03 into main Aug 27, 2026
35 checks passed
@ritchie46
ritchie46 deleted the nxs/pq-dict branch August 27, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-io-parquet Area: reading/writing Parquet files fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read plain encoded pages from Parquet for columns with an arrow dictionary type

2 participants