Hi,

8.4.6 fails to build against PostgreSQL 17. v17 beta2 is already out. Can you please take a look?

Thanks, Devrim

/usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-format-truncation -O2 -I"./" -I"-I/usr/include/R" -I/usr/include/R -I. -I./ -I/usr/pgsql-17/include/server -I/usr/pgsql-17/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -DWITH_GZFILEOP -I/usr/include -DPKGLIBDIR="/usr/pgsql-17/lib" -DDLSUFFIX=".so" -DR_HOME_DEFAULT="/usr/lib64/R" -flto=thin -emit-llvm -c -o pg_rsupport.bc pg_rsupport.c
In file included from plr.h:117,
from plr.c:33:
plr.c: In function ‘plr_convertargs’:
/usr/include/R/Rdefines.h:148:33: warning: ‘el’ may be used uninitialized [-Wmaybe-uninitialized]
148 | #define GET_LENGTH(x) Rf_length(x)
| ^~~~~~~~~~~~
plr.c:1628:25: note: ‘el’ was declared here
1628 | el;
| ^~
pg_userfuncs.c:414:2: error: call to undeclared function 'tuplestore_donestoring'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
414 | tuplestore_donestoring(tupstore);
| ^
1 error generated.
make[1]: *** [/usr/pgsql-17/lib/pgxs/src/makefiles/../../src/Makefile.global:1085: pg_userfuncs.bc] Error 1
make[1]: *** Waiting for unfinished jobs....
pg_conversion.c:2137:2: error: call to undeclared function 'tuplestore_donestoring'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2137 | tuplestore_donestoring(tupstore);
| ^
pg_conversion.c:2200:2: error: call to undeclared function 'tuplestore_donestoring'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2200 | tuplestore_donestoring(tupstore);
| ^
pg_conversion.c:2260:2: error: call to undeclared function 'tuplestore_donestoring'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2260 | tuplestore_donestoring(tupstore);
| ^
3 errors generated.
make[1]: *** [/usr/pgsql-17/lib/pgxs/src/makefiles/../../src/Makefile.global:1085: pg_conversion.bc] Error 1
pg_userfuncs.c: In function ‘plr_environ’:
pg_userfuncs.c:414:9: error: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Wimplicit-function-declaration]
414 | tuplestore_donestoring(tupstore);
| ^~~~~~~~~~~~~~~~~~~~~~
| tuplestore_rescan
make[1]: *** [: pg_userfuncs.o] Error 1
pg_conversion.c: In function ‘get_frame_tuplestore’:
pg_conversion.c:2137:9: error: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Wimplicit-function-declaration]
2137 | tuplestore_donestoring(tupstore);
| ^~~~~~~~~~~~~~~~~~~~~~
| tuplestore_rescan
make[1]: *** [: pg_conversion.o] Error 1