Skip to content

Обработка ошибок при remote restore #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ykurenkov opened this issue Jul 13, 2020 · 8 comments
Closed

Обработка ошибок при remote restore #240

ykurenkov opened this issue Jul 13, 2020 · 8 comments
Labels
bug
Milestone
2.4.9

Comments

@ykurenkov
Copy link

ykurenkov commented Jul 13, 2020 •
edited
Loading

Поведение замечено на версии 2.2.5. На более новых пока нет возможности смоделировать ситуацию и проверить. Суть проблемы в следующем. Восстанавливаем кластер на удалённый хост.

pg_probackup-10 restore -B /nfsbackup --instance ppak_kis ${id} --remote-host=${PGHOST} --remote-user=postgres --no-validate --log-level-console=VERBOSE --log-level-file=VERBOSE

В процессе восстановления на целевом разделе заканчивается место. Восстановление прерывается, лог файл и вывод в консоль обрываются на сообщении о последнем восстановленном файле без сообщения о том, что полностью восстановить не получилось.

2020-07-12 20:34:59 UTC: VERBOSE: Restored file /nfsbackup/backups/ppak_kis/QDBP05/database/base/83463823/95174632 : 172200 bytes
2020-07-12 20:34:59 UTC: VERBOSE: Restoring file "/nfsbackup/backups/ppak_kis/QDBP05/database/base/83463823/95174633", is_datafile 1, is_cfs 0
2020-07-12 20:35:05 UTC: VERBOSE: Restored file /nfsbackup/backups/ppak_kis/QDBP05/database/base/83463823/95174633 : 912414000 bytes
2020-07-12 20:35:05 UTC: VERBOSE: Restoring file "/nfsbackup/backups/ppak_kis/QDBP05/database/base/83463823/95174634", is_datafile 1, is_cfs 0
@ykurenkov
Copy link
Author

До августа буду в оффлайне.

@gsmolk
Copy link
Contributor

gsmolk commented Jul 13, 2020

Хмм, непорядок. Проверим

@gsmolk gsmolk added the bug label Jul 13, 2020
@gsmolk
Copy link
Contributor

gsmolk commented Jul 13, 2020

Да, подтверждаю, проблема актуальна на мастере.
Большое спасибо за фидбэк!

@gsmolk gsmolk added this to the 2.4.3 milestone Jul 13, 2020
@gsmolk
Copy link
Contributor

gsmolk commented Sep 25, 2020

Переношу на 2.4.5.
Фикс получается довольно нетривиальным.

@gsmolk gsmolk modified the milestones: 2.4.4, 2.4.5 Sep 25, 2020
@ykurenkov
Copy link
Author

Когда ждать 2.4.4? А то надо обновиться.

@gsmolk
Copy link
Contributor

gsmolk commented Sep 28, 2020

Когда ждать 2.4.4? А то надо обновиться.

Сегодня, часа через 3 будет.

@gsmolk
Copy link
Contributor

gsmolk commented Sep 28, 2020

Релизнулся

@gsmolk gsmolk modified the milestones: 2.4.5, 2.4.6 Nov 19, 2020
gsmolk added a commit that referenced this issue Jan 20, 2021
@gsmolk
[Issue #240] WIP
45ec518
gsmolk added a commit that referenced this issue Jan 21, 2021
@gsmolk
[Issue #240] WIP
405a017
gsmolk added a commit that referenced this issue Jan 22, 2021
@gsmolk
[Issue #240] When remote agent encounters an error condition during e…
83ba57f 
…xectuion of async task, save the error message and return it when requested. Also handle the SIGPIPE signal.
gsmolk added a commit that referenced this issue Jan 22, 2021
@gsmolk
[Issue #240] minor fixes
a37f8e5
gsmolk added a commit that referenced this issue Jan 25, 2021
@gsmolk
[Issue #240] improve comments thanks to Anastasia review
38c089f
gsmolk added a commit that referenced this issue Jan 26, 2021
@gsmolk
[Issue #240] Handle SIGPIPE. Also when remote agent encounters an err…
2e9c55f 
…or condition during exectuion of asynchronous tasks, the error message is saved in global variable and reported when agent status is checked
@gsmolk
Copy link
Contributor

gsmolk commented Jan 26, 2021

Смержено. Выйдет в 2.4.9

@gsmolk gsmolk closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.4.9
Development

No branches or pull requests
2 participants
@gsmolk @ykurenkov