Skip to content

Fix error handling and port management for Windows #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Fix error handling and port management for Windows #172

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0139bbd
[windows] TestgresTests is updated
dmitry-lipetsk Dec 25, 2024
660ab62
[windows] PostgresNode.start (LOCAL__start_node) is corrected
dmitry-lipetsk Dec 25, 2024
6465b41
A comment is added
dmitry-lipetsk Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[windows] PostgresNode.start (LOCAL__start_node) is corrected 
[BUG FIX] execute_utility may return None in error.
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Dec 25, 2024
commit 660ab62d96cda35d19ac69db556a986e4a241297
2 changes: 1 addition & 1 deletion testgres/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ def start(self, params=[], wait=True):

def LOCAL__start_node():
_, _, error = execute_utility(_params, self.utils_log_file, verbose=True)
assert type(error) == str # noqa: E721
assert error is None or type(error) == str # noqa: E721
if error and 'does not exist' in error:
raise Exception(error)

Expand Down