Skip to content

[BUG FIX] A problem with socket directory is fixed #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
A problem with tests.test_simple.TestgresTests.test_simple_with_bin_d…
…ir is fixed

testgres generates the exception testgres.exceptions.ExecUtilException, but test traps the exception FileNotFoundError.

Error message is:
 Utility exited with non-zero code. Error: `bash: line 1: wrong/path/postgres: No such file or directory`
 Command: ('wrong/path/postgres --version',)
  • Loading branch information
dmitry-lipetsk committed Feb 17, 2025
commit 89c8625252be857d8589141921aa185ac9db2d67
16 changes: 11 additions & 5 deletions tests/test_simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -1244,13 +1244,19 @@ def test_simple_with_bin_dir(self):
correct_bin_dir = app.make_simple(base_dir=node.base_dir, bin_dir=bin_dir)
correct_bin_dir.slow_start()
correct_bin_dir.safe_psql("SELECT 1;")
correct_bin_dir.stop()

while True:
try:
app.make_simple(base_dir=node.base_dir, bin_dir="wrong/path")
except FileNotFoundError:
break # Expected error
except ExecUtilException:
break # Expected error

try:
wrong_bin_dir = app.make_empty(base_dir=node.base_dir, bin_dir="wrong/path")
wrong_bin_dir.slow_start()
raise RuntimeError("Error was expected.") # We should not reach this
except FileNotFoundError:
pass # Expected error

return

def test_set_auto_conf(self):
# elements contain [property id, value, storage value]
Expand Down