Skip to content

RemoteOperations::exec_command explicitly transfers LANG, LANGUAGE and LC_* envvars to the server side #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 21, 2025
Merged

RemoteOperations::exec_command explicitly transfers LANG, LANGUAGE and LC_* envvars to the server side #187

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5fe166
RemoteOperations::exec_command updated
dmitry-lipetsk Feb 20, 2025
2b1db89
RemoteOperations::exec_command explicitly transfers LANG, LANGUAGE an…
dmitry-lipetsk Feb 20, 2025
4f0ba36
Merge commit '7fd2f07af75391503fb1c79a1bc9ec1f763923af' into D2025022…
dmitry-lipetsk Feb 20, 2025
4eb8330
New tests in TestgresRemoteTests are added
dmitry-lipetsk Feb 21, 2025
f4dc062
TestgresRemoteTests.test_init__unk_LANG_and_LC_CTYPE is updated
dmitry-lipetsk Feb 21, 2025
ee78bcd
Static methods are marked with @staticmethod [thanks to Victoria Shep…
dmitry-lipetsk Feb 21, 2025
5564938
TestRemoteOperations::_quote_envvar is updated (typification)
dmitry-lipetsk Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Static methods are marked with @staticmethod [thanks to Victoria Shep… 
…ard]

The following methods of RemoteOperations were corrected:
 - _make_exec_env_list
 - _does_put_envvar_into_exec_cmd
 - _quote_envvar
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Feb 21, 2025
commit ee78bcd2fc7002a1c3b5936425b3709c49d136aa
3 changes: 3 additions & 0 deletions testgres/operations/remote_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ def db_connect(self, dbname, user, password=None, host="localhost", port=5432):
)
return conn

@staticmethod
def _make_exec_env_list() -> list[str]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут нужно self, либо добавить @staticmethod

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self тут не нужен. Это статический метод.

Хорошо, я добавлю этот декоратор.

Я там в других местах тоже статические методы определял...

Тогда я пока только в новом коде этого PR его добавлю, а потом, отдельным коммитом, добавим его во все остальные случаи.

PS. Я этот питон на ходу изучаю, поэтому многие вещи использую неправильно ))))

result = list[str]()
for envvar in os.environ.items():
Expand All @@ -529,6 +530,7 @@ def _make_exec_env_list() -> list[str]:

sm_envs_for_exec_cmd = ["LANG", "LANGUAGE"]

@staticmethod
def _does_put_envvar_into_exec_cmd(name: str) -> bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут нужно self, либо добавить @staticmethod

assert type(name) == str # noqa: E721
name = name.upper()
Expand All @@ -538,6 +540,7 @@ def _does_put_envvar_into_exec_cmd(name: str) -> bool:
return True
return False

@staticmethod
def _quote_envvar(value) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут нужно self, либо добавить @staticmethod

assert type(value) == str # noqa: E721
result = "\""
Expand Down