Bugfix/prow 124 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtijdink
previously approved these changes
Jun 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches the PHPStan path settings from relative directories to absolute ones using %currentWorkingDirectory%.
- Replace
tests/anddatabase/factories/with%currentWorkingDirectory%-prefixed paths - Ensure PHPStan rules point to correct locations
Comments suppressed due to low confidence (2)
packages/php-linting-rules/configs/phpstan.neon:55
- [nitpick] Inconsistent spacing after the colon here–there are two spaces before
%currentWorkingDirectory%whereas other entries use one. Align spacing for readability.
path: %currentWorkingDirectory%/tests
packages/php-linting-rules/configs/phpstan.neon:57
- [nitpick] Ensure consistent indentation and spacing across all
path:entries—this one has one space after the colon versus two in other lines.
path: %currentWorkingDirectory%/database/factories
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
thomtijdink
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.