Skip to content

fix(tigera-operator): sanitize chart version labels - #13412

Merged
caseydavenport merged 1 commit into
projectcalico:masterfrom
xianjianlf2:fix/tigera-operator-uninstall-chart-label-13373
Aug 5, 2026
Merged

fix(tigera-operator): sanitize chart version labels#13412
caseydavenport merged 1 commit into
projectcalico:masterfrom
xianjianlf2:fix/tigera-operator-uninstall-chart-label-13373

Conversation

@xianjianlf2

Copy link
Copy Markdown
Contributor

Description

Sanitize helm.sh/chart labels on the Tigera Operator uninstall hook.

Helm chart versions may contain SemVer build metadata such as 3.32.1+77bd63307a97. The + character is invalid in Kubernetes label values, which prevents the pre-delete Job from being created during helm uninstall.

Changes

  • Replace + with _ in the Job's helm.sh/chart label.
  • Apply the same normalization to the Pod template label.

Fixes #13373.

Validation

Rendered the chart with version 3.32.1+77bd63307a97 using Helm v3.18.6 and verified both labels render as 3.32.1_77bd63307a97 with no + remaining.

Also ran git diff --check.

@xianjianlf2
xianjianlf2 requested a review from a team as a code owner August 4, 2026 06:52
@marvin-tigera marvin-tigera added this to the Calico v3.33.0 milestone Aug 4, 2026
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Aug 4, 2026
@CLAassistant

CLAassistant commented Aug 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@caseydavenport caseydavenport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks!

@caseydavenport

Copy link
Copy Markdown
Member

/sem-approve

@caseydavenport caseydavenport added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact merge-when-ready labels Aug 5, 2026
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Aug 5, 2026
@caseydavenport
caseydavenport merged commit 1c78219 into projectcalico:master Aug 5, 2026
5 of 10 checks passed
caseydavenport added a commit that referenced this pull request Aug 28, 2026
(cherry picked from commit 1c78219)

Co-authored-by: Mark Xian <mark-xian@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-candidate docs-not-required Docs not required for this change merge-when-ready release-note-not-required Change has no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninstall job fails, when tigera-operator is installed via FluxCD

4 participants