be tolerant when parsing the postgres version #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't particularly want to be more tolerant about version mismatches, since it can lead to subtly incorrect metrics (not a situation you want to be in). The correct fix here is to handle the 10.x version transition with the semver library properly, which will probably involve just appending a |
wrouesnel
added a commit
that referenced
this pull request
Oct 9, 2017
|
I'm not seeing why ParseTolerant is not a good fit, since it pretty much does that. |
|
You're right it is! I have an alternate fix sitting on another PR (adds a better regex check) but the integration tests are not reporting full metrics for postgres 10 yet so more work to do. |
ritbl
referenced
this pull request
in heniek/postgres_exporter
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.