Skip to content

fixed version parsing for Windows and EnterpriseDB #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

marcinbudny
Copy link
Contributor

Fixes #142

@coveralls
Copy link

coveralls commented Jan 31, 2018

Coverage Status

Coverage remained the same at 54.701% when pulling 3fd55f1 on marcinbudny:master into 5b9fea0 on wrouesnel:master.

@marcinbudny
Copy link
Contributor Author

I'm new to golang and I'm not really sure why the build fails. The output at one point says:

postgres_exporter_test.go:1::warning: file is not gofmted with -s (gofmt)
make: *** [style] Error 1
The command "make all" exited with 2.

However when I run go fmt locally, files are not changed. The output does not specify any other broken rule. Any help?

@wrouesnel
Copy link
Contributor

@marcinbudny run "make fmt" instead.

@marcinbudny
Copy link
Contributor Author

@wrouesnel That helped, thanks

@wrouesnel
Copy link
Contributor

Looks great! Appreciate the tests - merging.

@wrouesnel wrouesnel merged commit b0d5700 into prometheus-community:master Feb 2, 2018
ritbl referenced this pull request in heniek/postgres_exporter Mar 19, 2023
* fixed version parsing for Windows and EnterpriseDB

* fixed formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants