Add a build info metric #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
version_metric
branch
from
c795cbf to
f0ad1cf
Compare
|
I'm not sure the best way to add test coverage for the additional code. |
|
I'm content with the test coverage, but could you rebase the vendoring changes into one commit? |
|
Sure, no problem |
SuperQ
force-pushed
the
version_metric
branch
2 times, most recently
from
90782ff to
547f01c
Compare
|
Fast-forward rebased and squashed the vendor change. |
Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <[email protected]>
Add a standard Prometheus build info metric to make monitoring rollouts easier.
SuperQ
force-pushed
the
version_metric
branch
from
547f01c to
3c1810f
Compare
english
pushed a commit
to form3tech-oss/postgres_exporter
that referenced
this pull request
Jan 31, 2020
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <[email protected]> (cherry picked from commit aeec47e)
english
pushed a commit
to form3tech-oss/postgres_exporter
that referenced
this pull request
Jan 31, 2020
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <[email protected]> (cherry picked from commit aeec47e)
ritbl
referenced
this pull request
in heniek/postgres_exporter
Mar 19, 2023
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <[email protected]>
alessio-form3
pushed a commit
to form3tech-oss/postgres_exporter
that referenced
this pull request
Oct 10, 2023
* Add a build info metric Add a standard Prometheus build info metric to make monitoring rollouts easier. * Update prometheus vendoring. * Fix build error Fix missing bool in builtinMetricMaps. Signed-off-by: Ben Kochie <[email protected]> (cherry picked from commit aeec47e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a standard Prometheus build info metric to make monitoring rollouts
easier.