Skip to content

Use correct SemVer range condition #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dominikschulz
Copy link
Contributor

@dominikschulz dominikschulz commented Nov 28, 2016

Sorry for the unrelated changes, apparently the code wasn't properly gofmt'd before.

Fixes #38

@wrouesnel
Copy link
Contributor

Oh wow, literally 1 missing ! character. Nice find.

I'll merge this but then add some logging around that discard function.

@wrouesnel wrouesnel merged commit 8f30886 into prometheus-community:master Nov 28, 2016
wrouesnel added a commit that referenced this pull request Nov 28, 2016
Related issue is #38. Time to start expanding functional test coverage since
the integration tests missed this.
wrouesnel added a commit that referenced this pull request Nov 28, 2016
Related issue is #38. Time to start expanding functional test coverage since
the integration tests missed this.
wrouesnel added a commit that referenced this pull request Nov 28, 2016
Related issue is #38. Time to start expanding functional test coverage since
the integration tests missed this.
wrouesnel added a commit that referenced this pull request Nov 28, 2016
Related issue is #38. Time to start expanding functional test coverage since
the integration tests missed this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants