-
Notifications
You must be signed in to change notification settings - Fork 774
Improve PostgreSQL replication lag detection #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wrouesnel
merged 1 commit into
prometheus-community:master
from
jsosic:fix-psql-replication-lag
Dec 24, 2020
Merged
Improve PostgreSQL replication lag detection #395
wrouesnel
merged 1 commit into
prometheus-community:master
from
jsosic:fix-psql-replication-lag
Dec 24, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases master can show pg_last_xact_replay_timestamp() from past, which can cause the exporter to show ever-growing value for the lag. By checking if the instance is in recovery we can avoid reporting some huge number for master instance.
SuperQ
added a commit
that referenced
this pull request
Feb 26, 2021
* Add CHANGELOG from existing tags. Now released under Prometheus Community * [CHANGE] Update build to use standard Prometheus promu/Dockerfile * [ENHANCEMENT] Remove duplicate column in queries.yml #433 * [ENHANCEMENT] Add query for 'pg_replication_slots' #465 * [ENHANCEMENT] Allow a custom prefix for metric namespace #387 * [ENHANCEMENT] Improve PostgreSQL replication lag detection #395 * [ENHANCEMENT] Support connstring syntax when discovering databases #473 * [ENHANCEMENT] Detect SIReadLock locks in the pg_locks metric #421 * [BUGFIX] Fix pg_database_size_bytes metric in queries.yaml #357 * [BUGFIX] Don't ignore errors in parseUserQueries #362 * [BUGFIX] Fix queries.yaml for AWS RDS #370 * [BUGFIX] Recover when connection cannot be established at startup #415 * [BUGFIX] Don't retry if an error occurs #426 * [BUGFIX] Do not panic on incorrect env #457 Signed-off-by: Ben Kochie <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Mar 1, 2021
* Add CHANGELOG from existing tags. First release under the Prometheus Community organisation. * [CHANGE] Update build to use standard Prometheus promu/Dockerfile * [ENHANCEMENT] Remove duplicate column in queries.yml #433 * [ENHANCEMENT] Add query for 'pg_replication_slots' #465 * [ENHANCEMENT] Allow a custom prefix for metric namespace #387 * [ENHANCEMENT] Improve PostgreSQL replication lag detection #395 * [ENHANCEMENT] Support connstring syntax when discovering databases #473 * [ENHANCEMENT] Detect SIReadLock locks in the pg_locks metric #421 * [BUGFIX] Fix pg_database_size_bytes metric in queries.yaml #357 * [BUGFIX] Don't ignore errors in parseUserQueries #362 * [BUGFIX] Fix queries.yaml for AWS RDS #370 * [BUGFIX] Recover when connection cannot be established at startup #415 * [BUGFIX] Don't retry if an error occurs #426 * [BUGFIX] Do not panic on incorrect env #457 Signed-off-by: Ben Kochie <[email protected]>
angaz
pushed a commit
to angaz/postgres_exporter
that referenced
this pull request
Mar 3, 2022
* Add CHANGELOG from existing tags. First release under the Prometheus Community organisation. * [CHANGE] Update build to use standard Prometheus promu/Dockerfile * [ENHANCEMENT] Remove duplicate column in queries.yml prometheus-community#433 * [ENHANCEMENT] Add query for 'pg_replication_slots' prometheus-community#465 * [ENHANCEMENT] Allow a custom prefix for metric namespace prometheus-community#387 * [ENHANCEMENT] Improve PostgreSQL replication lag detection prometheus-community#395 * [ENHANCEMENT] Support connstring syntax when discovering databases prometheus-community#473 * [ENHANCEMENT] Detect SIReadLock locks in the pg_locks metric prometheus-community#421 * [BUGFIX] Fix pg_database_size_bytes metric in queries.yaml prometheus-community#357 * [BUGFIX] Don't ignore errors in parseUserQueries prometheus-community#362 * [BUGFIX] Fix queries.yaml for AWS RDS prometheus-community#370 * [BUGFIX] Recover when connection cannot be established at startup prometheus-community#415 * [BUGFIX] Don't retry if an error occurs prometheus-community#426 * [BUGFIX] Do not panic on incorrect env prometheus-community#457 Signed-off-by: Ben Kochie <[email protected]>
ritbl
pushed a commit
to heniek/postgres_exporter
that referenced
this pull request
Mar 19, 2023
In some cases master can show pg_last_xact_replay_timestamp() from past, which can cause the exporter to show ever-growing value for the lag. By checking if the instance is in recovery we can avoid reporting some huge number for master instance.
ritbl
pushed a commit
to heniek/postgres_exporter
that referenced
this pull request
Mar 19, 2023
* Add CHANGELOG from existing tags. First release under the Prometheus Community organisation. * [CHANGE] Update build to use standard Prometheus promu/Dockerfile * [ENHANCEMENT] Remove duplicate column in queries.yml prometheus-community#433 * [ENHANCEMENT] Add query for 'pg_replication_slots' prometheus-community#465 * [ENHANCEMENT] Allow a custom prefix for metric namespace prometheus-community#387 * [ENHANCEMENT] Improve PostgreSQL replication lag detection prometheus-community#395 * [ENHANCEMENT] Support connstring syntax when discovering databases prometheus-community#473 * [ENHANCEMENT] Detect SIReadLock locks in the pg_locks metric prometheus-community#421 * [BUGFIX] Fix pg_database_size_bytes metric in queries.yaml prometheus-community#357 * [BUGFIX] Don't ignore errors in parseUserQueries prometheus-community#362 * [BUGFIX] Fix queries.yaml for AWS RDS prometheus-community#370 * [BUGFIX] Recover when connection cannot be established at startup prometheus-community#415 * [BUGFIX] Don't retry if an error occurs prometheus-community#426 * [BUGFIX] Do not panic on incorrect env prometheus-community#457 Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases master can show
pg_last_xact_replay_timestamp()
from past, which can cause the exporter to show ever-growing value for the lag. This fixes the issue.I've got the idea for fix from:
Example (from master):
Same master, fixed query:
Master recovery status:
Streaming slave:
Paused slave:
From the documentation:
True if recovery is still in progress.