Skip to content

Fix cargo-raze version and check the diff. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PiotrSikora merged 19 commits into from
Dec 7, 2020
Merged

Fix cargo-raze version and check the diff. #107

PiotrSikora merged 19 commits into from
Dec 7, 2020

Conversation

@mathetake
Copy link
Contributor

@mathetake mathetake commented Nov 23, 2020 •
edited
Loading

resolve #106

@mathetake
Set working directory
93b3e51 
Signed-off-by: mathetake <[email protected]>
@mathetake
Change cargo cache key
773f6ee 
Signed-off-by: mathetake <[email protected]>
@mathetake
Use cargo-raze 0.7.0
39fb6f1 
Signed-off-by: mathetake <[email protected]>
@mathetake
Fix style
f4c8efb 
Signed-off-by: mathetake <[email protected]>
@mathetake
Fix workflow for cargo-raze
f159ec2 
Signed-off-by: mathetake <[email protected]>
PiotrSikora
PiotrSikora requested changes Dec 4, 2020
View reviewed changes
@mathetake mathetake requested a review from PiotrSikora December 4, 2020 07:23
PiotrSikora
PiotrSikora reviewed Dec 4, 2020
View reviewed changes
@mathetake mathetake changed the title CI: fix cargo-raze version and check the diff. Fix cargo-raze version and check the diff. Dec 6, 2020
@mathetake
Fix crate loads
f8e8745 
Signed-off-by: mathetake <[email protected]>
@mathetake
Update: cargo generate-lockfile
ca2f5e8 
Signed-off-by: mathetake <[email protected]>
@mathetake
Re cargo-raze
5110831 
Signed-off-by: mathetake <[email protected]>
@mathetake mathetake requested a review from PiotrSikora December 6, 2020 11:53
PiotrSikora
PiotrSikora approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/cargo.yml
branches:
- master
paths:
- 'bazel/cargo/**'
Copy link
Member

@PiotrSikora PiotrSikora Dec 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@PiotrSikora
Copy link
Member

PiotrSikora commented Dec 6, 2020

Could you merge with master and resolve conflicts? Thanks!

PiotrSikora
PiotrSikora reviewed Dec 6, 2020
View reviewed changes
@mathetake
Fix the broken merge
d1bac1b 
Signed-off-by: mathetake <[email protected]>
PiotrSikora
PiotrSikora approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora
Copy link
Member

PiotrSikora commented Dec 7, 2020

You need to regenerate cargo-raze artifacts.

@mathetake
Re cargo-raze
dfe0e02 
Signed-off-by: mathetake <[email protected]>
@mathetake
Copy link
Contributor Author

mathetake commented Dec 7, 2020

done

@PiotrSikora PiotrSikora merged commit fd005dc into proxy-wasm:master Dec 7, 2020
@mathetake mathetake deleted the cargo-raze-ci branch December 7, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: fix cargo-raze version and check the diff

2 participants

@mathetake @PiotrSikora