Skip to content

Register the queue cleanup callback to vm_id handle callbacks #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PiotrSikora merged 16 commits into from
Dec 15, 2020
Merged

Register the queue cleanup callback to vm_id handle callbacks #114

PiotrSikora merged 16 commits into from
Dec 15, 2020

Conversation

@mathetake
Copy link
Contributor

@mathetake mathetake commented Dec 8, 2020

@mathetake mathetake mentioned this pull request Dec 8, 2020
Closed
@mathetake mathetake marked this pull request as ready for review December 8, 2020 06:28
@mathetake
Copy link
Contributor Author

mathetake commented Dec 8, 2020

something broken envoyproxy/envoy#14315 😞 will take a look tomorrow

@PiotrSikora
Copy link
Member

PiotrSikora commented Dec 8, 2020

something broken envoyproxy/envoy#14315 😞 will take a look tomorrow

I'm afraid that's because of changes in #99 (notably, initialization-order-fiasco because global_shared_data gets initialized before global_vm_id_handle_callbacks on which it depends due to registerVmIdHandleCallback).

@mathetake
Copy link
Contributor Author

mathetake commented Dec 8, 2020

ooops, that makes sense. Thanks

@mathetake
Copy link
Contributor Author

mathetake commented Dec 9, 2020

so now only thing to solve is Windows build failure...

@mathetake mathetake mentioned this pull request Dec 10, 2020
Merged
@mathetake
Copy link
Contributor Author

mathetake commented Dec 10, 2020

wait until #115 is merged

mathetake
mathetake commented Dec 10, 2020
View reviewed changes
@mathetake
Fix shared_data test
f957f72 
stop registering global_callback in unittest other than VmIdHandleCleanup

Signed-off-by: mathetake <[email protected]>
@mathetake
Style: revert unnecessary change in queue test
ee6b816 
Signed-off-by: mathetake <[email protected]>
PiotrSikora
PiotrSikora approved these changes Dec 11, 2020
View reviewed changes
@PiotrSikora PiotrSikora requested a review from lizan December 11, 2020 09:48
PiotrSikora
PiotrSikora reviewed Dec 12, 2020
View reviewed changes
PiotrSikora
PiotrSikora reviewed Dec 14, 2020
View reviewed changes
PiotrSikora
PiotrSikora reviewed Dec 15, 2020
View reviewed changes
@PiotrSikora PiotrSikora merged commit b1067e6 into proxy-wasm:master Dec 15, 2020
@PiotrSikora
Copy link
Member

PiotrSikora commented Dec 15, 2020

Thanks!

@mathetake mathetake deleted the queue-leak branch December 15, 2020 07:31
This was referenced Dec 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@lizan lizan Awaiting requested review from lizan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shared data and shared queue leak on VM change

2 participants

@mathetake @PiotrSikora