Skip to content

Conversation

@PiotrSikora
Copy link
Member

Signed-off-by: Piotr Sikora [email protected]

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora
Copy link
Member Author

I originally tried to add more template specializations to cover the "no parameters" variants, but that resulted in errors, since void func(void) was matching 3 different specializations:

external/proxy_wasm_cpp_host/src/v8/v8.cc:609:10: error: function template specialization 'getModuleFunctionImpl' ambiguously refers to more than one function template; explicitly specify template arguments to identify a particular function template
void V8::getModuleFunctionImpl(std::string_view function_name,
         ^
external/proxy_wasm_cpp_host/src/v8/v8.cc:115:8: note: function template 'proxy_wasm::(anonymous namespace)::V8::getModuleFunctionImpl<void>' matches specialization [with R = void, Args = <>]
  void getModuleFunctionImpl(std::string_view function_name,
       ^
external/proxy_wasm_cpp_host/src/v8/v8.cc:107:8: note: function template 'proxy_wasm::(anonymous namespace)::V8::getModuleFunctionImpl<void>' matches specialization [with R = void]
  void getModuleFunctionImpl(std::string_view function_name,
       ^
external/proxy_wasm_cpp_host/src/v8/v8.cc:111:8: note: function template 'proxy_wasm::(anonymous namespace)::V8::getModuleFunctionImpl<>' matches specialization [with Args = <>]
  void getModuleFunctionImpl(std::string_view function_name,

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora
Copy link
Member Author

@mathetake PTAL.

Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@PiotrSikora PiotrSikora merged commit 38e6dbd into proxy-wasm:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants