Skip to content

v8: use signal handlers to catch out of bounds memory access. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PiotrSikora merged 3 commits into from
Apr 1, 2021
Merged

v8: use signal handlers to catch out of bounds memory access. #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01df058
v8: use signal handlers to catch out of bounds memory access.
PiotrSikora Apr 1, 2021
8fdfecd
review: use std::call_once.
PiotrSikora Apr 1, 2021
d0d0076
review: fix build with GCC.
PiotrSikora Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/v8/v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,29 @@
#include <cassert>
#include <iomanip>
#include <memory>
#include <mutex>
#include <optional>
#include <sstream>
#include <unordered_map>
#include <utility>
#include <vector>

#include "v8.h"
#include "v8-version.h"
#include "wasm-api/wasm.hh"

namespace proxy_wasm {
namespace {

wasm::Engine *engine() {
static const auto engine = wasm::Engine::make();
static std::once_flag init;
static wasm::own<wasm::Engine> engine;

std::call_once(init, []() {
v8::V8::EnableWebAssemblyTrapHandler(true);
engine = wasm::Engine::make();
});

return engine.get();
}

Expand Down