-
Notifications
You must be signed in to change notification settings - Fork 80
wasmtime: update to v0.30.0. #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ryan Northey <[email protected]>
0865b88 to
f152086
Compare
|
Signed-off-by: Ryan Northey <[email protected]>
588a3ef to
852223d
Compare
|
thanks, updated |
PiotrSikora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to bump versions to v0.30.0 in bazel/cargo/Cargo.toml and regenerate crates again.
|
thanks, i updated again i had to remove the path from the |
wasmtime -> 0.30.0|
@PiotrSikora not sure how to resolve the error in CI i bumped the grepping, and looking at the log failure it seems like there is a bazel dependency on version |
PiotrSikora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grepping, and looking at the log failure it seems like there is a bazel dependency on version 0.19.0 - not sure if that is related
0.19.0 is the version of wasmtime-c-api-macros crate, but it's not published, so we're downloading it from wasmtime's repo.
bazel/cargo/Cargo.toml
Outdated
| once_cell = "1.3" | ||
| wasmtime = {version = "0.26.0", default-features = false} | ||
| wasmtime-c-api-macros = {git = "https://github.com/bytecodealliance/wasmtime", tag = "v0.26.0", path = "crates/c-api/macros"} | ||
| wasmtime = {version = "0.30.0", default-features = false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add , features = ['cranelift'] in wasmtime dependency (that's new in v0.30.0 and I ended up diffing changes in wasmtime to figure it out...). Once you regenerate crates (again), it should work fine.
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
b9a99f0 to
11a6505
Compare
|
updated and regenerated lockfile - force-pushed to fix DCO |
PiotrSikora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the package version from 0.25.0 to 0.30.0 in bazel/cargo/Cargo.toml as well? Thanks!
Signed-off-by: Ryan Northey <[email protected]>
|
It looks that Cranelift needs a more recent version of Rust. See: #195. |
is that in CI/repo - or my local version? I think i have a pretty recent version locally, so im guessing the former |
|
Both, since Bazel is using Rust version from |
PiotrSikora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
attempting to update wasmtime in Envoy main (cf envoyproxy/envoy#18499 (review))
not sure how to regenerate crates