Handle error cases gracefully. WASM -> Wasm. #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <[email protected]>
PiotrSikora
approved these changes
May 20, 2020
| inline void *WasmBase::allocMemory(uint64_t size, uint64_t *address) { | ||
| if (!malloc_) { | ||
| return nullptr; | ||
| } |
Member
There was a problem hiding this comment.
Do we need this? We fail hard if malloc is not exported.
(I'm not saying it's not good to add it just to be safe, I'm just curious why did you add it now)
Contributor
Author
There was a problem hiding this comment.
Generally I was trying to make the proxy-independent code resilient against unexpected behavior. An integrator could choose to not hard fail on error(). For envoy we throw an exception which we will catch at a higher level, but presumably someone code set a flag.
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak [email protected]