Skip to content

Conversation

@PiotrSikora
Copy link
Member

@PiotrSikora PiotrSikora commented Feb 8, 2022

This currently doesn't work with rules_rust, so Rust targets,
including the test data, cannot be built when using it.

See #243 for a workaround.

Signed-off-by: Piotr Sikora [email protected]

Note that bazel-zig-cc breaks rules_rust, so the Rust test data cannot
be build when using it, which prevents test binaries from being built.

See proxy-wasm#243 for a workaround.

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora marked this pull request as ready for review February 8, 2022 11:27
@PiotrSikora
Copy link
Member Author

@motiejus, FYI

@motiejus
Copy link

motiejus commented Feb 8, 2022

@motiejus, FYI

Thank you for the heads up. I really like the .bazelrc changes, and will be recommending that instead.

Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@PiotrSikora PiotrSikora merged commit 5a61399 into proxy-wasm:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants