Skip to content

test: verify that we can print stacktraces. #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PiotrSikora wants to merge 3 commits into from
Closed

test: verify that we can print stacktraces. #255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22e6964
test: verify that we can print stacktraces.
PiotrSikora Feb 10, 2022
0e5196f
Merge remote-tracking branch 'origin/master' into PiotrSikora/test-st…
PiotrSikora Feb 17, 2022
2710a5f
review: fix bad merge.
PiotrSikora Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions test/runtime_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <string>
#include <vector>

#include "include/proxy-wasm/bytecode_util.h"
#include "include/proxy-wasm/context.h"
#include "include/proxy-wasm/wasm.h"

Expand Down Expand Up @@ -233,16 +234,32 @@ TEST_P(TestVM, Callback) {

TEST_P(TestVM, Trap) {
auto source = readTestWasmFile("trap.wasm");
ASSERT_TRUE(vm_->load(source, {}, {}));
std::unordered_map<uint32_t, std::string> function_names;
EXPECT_TRUE(BytecodeUtil::getFunctionNameIndex(source, function_names));
ASSERT_TRUE(vm_->load(source, {}, function_names));
ASSERT_TRUE(vm_->link(""));
TestContext context;
WasmCallVoid<0> trigger;
vm_->getFunction("trigger", &trigger);
EXPECT_TRUE(trigger != nullptr);
ASSERT_TRUE(trigger != nullptr);
trigger(&context);
std::string exp_message = "Function: trigger failed";
auto integration = static_cast<DummyIntegration *>(vm_->integration().get());
ASSERT_TRUE(integration->error_message_.find(exp_message) != std::string::npos);
EXPECT_TRUE(integration->error_message_.find(exp_message) != std::string::npos);

if (engine_ == "wamr" || engine_ == "wasmtime") {
// TODO(PiotrSikora): Stacktrace not supported in WAMR and Wasmtime.
return;
}
exp_message = "Proxy-Wasm plugin in-VM backtrace:";
EXPECT_TRUE(integration->error_message_.find(exp_message) != std::string::npos);

if (engine_ == "wavm") {
// WAVM uses custom format for stacktraces.
return;
}
exp_message = " - trigger";
EXPECT_TRUE(integration->error_message_.find(exp_message) != std::string::npos);
}

TEST_P(TestVM, Trap2) {
Expand All @@ -258,11 +275,11 @@ TEST_P(TestVM, Trap2) {
TestContext context;
WasmCallWord<1> trigger2;
vm_->getFunction("trigger2", &trigger2);
EXPECT_TRUE(trigger2 != nullptr);
ASSERT_TRUE(trigger2 != nullptr);
trigger2(&context, 0);
std::string exp_message = "Function: trigger2 failed";
auto integration = static_cast<DummyIntegration *>(vm_->integration().get());
ASSERT_TRUE(integration->error_message_.find(exp_message) != std::string::npos);
EXPECT_TRUE(integration->error_message_.find(exp_message) != std::string::npos);
}

} // namespace
Expand Down