Skip to content

Remove bad check during buffer write. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplevyak merged 1 commit into from
Jun 25, 2020
Merged

Remove bad check during buffer write. #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/exports.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,10 +514,6 @@ Word set_buffer_bytes(void *raw_context, Word type, Word start, Word length, Wor
if (!data) {
return WasmResult::InvalidMemoryAccess;
}
// check for overflow.
if (buffer->size() < start + length || start > start + length) {
return WasmResult::BadArgument;
}
return buffer->copyFrom(start, length, data.value());
}

Expand Down