Skip to content

Remove default implementations from headers. #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PiotrSikora merged 5 commits into from
Mar 3, 2022
Merged

Remove default implementations from headers. #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6dae67
remove default implementation of time api
Mar 1, 2022
4653dad
implement time interface for test context
Mar 2, 2022
cb9e7c3
resolve conflict
Mar 2, 2022
bce3ba1
add duration cast
Mar 2, 2022
6f26fe7
Merge branch 'master' into remove_dummy_get_time
PiotrSikora Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions include/proxy-wasm/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,12 +237,17 @@ class ContextBase : public RootInterface,
WasmResult log(uint32_t /* level */, std::string_view /* message */) override {
return unimplemented();
}
uint32_t getLogLevel() override { return static_cast<uint32_t>(LogLevel::info); }
uint32_t getLogLevel() override {
unimplemented();
return 0;
}
uint64_t getCurrentTimeNanoseconds() override {
return std::chrono::system_clock::now().time_since_epoch().count();
unimplemented();
return 0;
}
uint64_t getMonotonicTimeNanoseconds() override {
return std::chrono::steady_clock::now().time_since_epoch().count();
unimplemented();
return 0;
}
std::string_view getConfiguration() override {
unimplemented();
Expand Down
11 changes: 11 additions & 0 deletions test/utility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,17 @@ class TestContext : public ContextBase {

bool isLogged(std::string_view message) { return log_.find(message) != std::string::npos; }

uint64_t getCurrentTimeNanoseconds() override {
return std::chrono::duration_cast<std::chrono::nanoseconds>(
std::chrono::system_clock::now().time_since_epoch())
.count();
}
uint64_t getMonotonicTimeNanoseconds() override {
return std::chrono::duration_cast<std::chrono::nanoseconds>(
std::chrono::steady_clock::now().time_since_epoch())
.count();
}

private:
std::string log_;
};
Expand Down