Bound maximum size of random_get buffer. #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmcquade
changed the title
mathetake
reviewed
Apr 15, 2022
Contributor
|
Want to add tests in https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/master/test/exports_test.cc ? |
bryanmcquade
force-pushed
the
random_get_fix
branch
from
51f7ec6 to
925c038
Compare
added 3 commits
April 14, 2022 21:11
Signed-off-by: Bryan McQuade <[email protected]>
Signed-off-by: Bryan McQuade <[email protected]>
Updates Crypto.getRandomValues() link to point to the spec (canonical source). Signed-off-by: Bryan McQuade <[email protected]>
bryanmcquade
force-pushed
the
random_get_fix
branch
from
b9a23f7 to
8b67bd8
Compare
Signed-off-by: Bryan McQuade <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Member
Done, PTAL. |
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
mathetake
approved these changes
Apr 15, 2022
knm3000
pushed a commit
to knm3000/proxy-wasm-cpp-host
that referenced
this pull request
Aug 17, 2022
Signed-off-by: Bryan McQuade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, random_get will return an error for buffers larger than 64kB.
This is consistent with the JavaScript Crypto.getRandomValues() maximum buffer size.