Skip to content

rustc_flags linker flag no longer needed for s390x #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathetake merged 1 commit into from
Feb 6, 2023
Merged

rustc_flags linker flag no longer needed for s390x #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions bazel/wasm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ wasi_rust_binary_rule = rule(
attrs = _wasm_attrs(wasi_rust_transition),
)

def wasm_rust_binary(name, tags = [], wasi = False, signing_key = [], rustc_flags = [], **kwargs):
def wasm_rust_binary(name, tags = [], wasi = False, signing_key = [], **kwargs):
wasm_name = "_wasm_" + name.replace(".", "_")
kwargs.setdefault("visibility", ["//visibility:public"])

Expand All @@ -87,11 +87,6 @@ def wasm_rust_binary(name, tags = [], wasi = False, signing_key = [], rustc_flag
crate_type = "cdylib",
out_binary = True,
tags = ["manual"],
# Rust doesn't distribute rust-lld for Linux/s390x.
rustc_flags = rustc_flags + select({
"//bazel:linux_s390x": ["-C", "linker=/usr/bin/lld"],
"//conditions:default": [],
}),
**kwargs
)

Expand Down