deps: bump wasmtime => 6.0.0 #330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiverPhillips
force-pushed
the
master
branch
from
554dc4e to
d2ef7b0
Compare
RiverPhillips
changed the title
RiverPhillips
force-pushed
the
master
branch
from
8af4c77 to
d86dc5a
Compare
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
RiverPhillips
force-pushed
the
master
branch
from
5ffee50 to
fadf474
Compare
PiotrSikora
reviewed
Feb 26, 2023
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Wasmtime usually bleeding edge Rust features, so you might need to update rules_rust to latest version to pull a more recent version of Rust for Wasmtime v6.0.0 to compile.
Comment on lines
166
to
176
| ): [ | ||
| "@wasmtime__linux_raw_sys__0_0_46//:linux_raw_sys", | ||
| ], | ||
| "//conditions:default": [], | ||
| }) + selects.with_or({ | ||
| # cfg(any(rustix_use_libc, miri, not(all(target_os = "linux", any(target_arch = "x86", all(target_arch = "x86_64", target_pointer_width = "64"), all(target_endian = "little", any(target_arch = "arm", all(target_arch = "aarch64", target_pointer_width = "64"), target_arch = "powerpc64", target_arch = "riscv64", target_arch = "mips", target_arch = "mips64"))))))) | ||
| ( | ||
| "@rules_rust//rust/platform:i686-unknown-linux-gnu", | ||
| "@rules_rust//rust/platform:x86_64-unknown-linux-gnu", | ||
| "@rules_rust//rust/platform:aarch64-unknown-linux-gnu", | ||
| "@rules_rust//rust/platform:arm-unknown-linux-gnueabi", |
Member
There was a problem hiding this comment.
This shouldn't be removed. That's why you're seeing all those errors about missing linux_raw_sys.
Always try to verify the diff between the old and new version of the patch. That's the easiest way to spot issues.
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
RiverPhillips
force-pushed
the
master
branch
from
455cd91 to
80eb60c
Compare
Member
|
@RiverPhillips please look at the diff between existing and new versions of Bazel rules for |
Contributor
Author
|
I'm going to close this an re-open a new PR for 6.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.