wamr: avoids .wasm binary content copying. #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse `bytecode` instead of creating and copy the binary content during `wasm_byte_vec_new()` Signed-off-by: [email protected] <[email protected]>
lum1n0us
force-pushed
the
reuse_binary_content
branch
from
14b652e to
47d9137
Compare
mathetake
changed the title
mathetake
reviewed
Mar 16, 2023
mathetake
approved these changes
Mar 16, 2023
Member
|
Should the same change be done for the other Wasm engines? |
johnlanni
pushed a commit
to higress-group/proxy-wasm-cpp-host
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse
bytecodeinstead of creating and copy the binary content duringwasm_byte_vec_new()