Skip to content

Conversation

@RiverPhillips
Copy link
Contributor

No description provided.

@RiverPhillips RiverPhillips changed the title deps: bump rust -> 1.68.0 Update rules_rust to v0.19.0 (with Rust v1.68.0) Mar 19, 2023
Signed-off-by: River phillips <[email protected]>
Signed-off-by: River phillips <[email protected]>
Signed-off-by: River phillips <[email protected]>
Signed-off-by: River phillips <[email protected]>
@PiotrSikora
Copy link
Member

The V8 failure is due to the internal function name change, you can fix it by changing:

host->isErrorLogged(" - rust_oom")

to

host->isErrorLogged("rust_oom")

in test/runtime_test.cc at line 145.

Signed-off-by: River phillips <[email protected]>
@PiotrSikora PiotrSikora changed the title Update rules_rust to v0.19.0 (with Rust v1.68.0) Update rules_rust to v0.19.0 (with Rust v1.68.0). Mar 20, 2023
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit cc3864b into proxy-wasm:master Mar 20, 2023
@RiverPhillips RiverPhillips deleted the rust-update branch March 20, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants