Skip to content

Conversation

@martijneken
Copy link
Contributor

No description provided.

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the CI with hermetic_cc_toolchain before merging anything.

@PiotrSikora
Copy link
Member

Looks good, but you need to fix the DCO bot (the Signed-off-by line must be present in all commits).

git commit --amend --signoff && git push --force ...

Signed-off-by: Martijn Stevenson <[email protected]>
@martijneken
Copy link
Contributor Author

martijneken commented Apr 26, 2023

Looks good, but you need to fix the DCO bot (the Signed-off-by line must be present in all commits).

Thanks, done.

We need to fix the CI with hermetic_cc_toolchain before merging anything.

ACK. #345

@martijneken
Copy link
Contributor Author

Added CI for GCC and v8. Still blocked on #345

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title Fix v8 gcc Bazel build using -Wno-nonnull. Fixes #340. v8: fix build with GCC. Apr 28, 2023
@PiotrSikora PiotrSikora merged commit 491915a into proxy-wasm:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants