Skip to content

Conversation

@phmx
Copy link
Contributor

@phmx phmx commented Jul 2, 2023

Use SHA256 hash for plugin cache key. Otherwise, a raw plugin config (concatenated with root ID and key) is stored in the key which may cause unnecessary memory consumption.

Use SHA256 hash for plugin cache key. Otherwise, a raw plugin
config (concatenated with root ID and key) is stored in the key which
may cause unnecessary memory consumption.

Signed-off-by: Maxim Philippov <[email protected]>
@phmx phmx force-pushed the sha-hash-plugins-cache-keys branch from ad0aaa8 to d493cc6 Compare July 2, 2023 11:11
@PiotrSikora PiotrSikora changed the title Use SHA256 hash for plugin cache Use SHA256 hash for plugin cache. Jul 2, 2023
@PiotrSikora PiotrSikora requested review from kyessenov and mpwarres July 2, 2023 22:44
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mpwarres mpwarres merged commit c932df1 into proxy-wasm:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants