[wamr] skip leading paddings in .aot section #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
changed the title
|
Perhaps we should separate this into 2 PRs? |
Member
It seems that skipping is done only for AOT, so I don't see a reason for it to be 2 separate PRs. |
Contributor
Author
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
2 times, most recently
from
bc6cd28 to
3ed8a53
Compare
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
3ed8a53 to
0a59fbd
Compare
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
2 times, most recently
from
f85fa55 to
e48526a
Compare
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
2 times, most recently
from
69f34bf to
817b73a
Compare
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
817b73a to
0381ddb
Compare
PiotrSikora
approved these changes
Aug 21, 2024
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
0381ddb to
7236f41
Compare
Contributor
Author
|
@mpwarres @martijneken any update? |
mpwarres
approved these changes
Sep 9, 2024
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
LGTM mod a few superficial nits. Thanks!
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
7236f41 to
42b6769
Compare
martijneken
added a commit
to martijneken/proxy-wasm-cpp-host
that referenced
this pull request
Sep 10, 2024
Seen on proxy-wasm#380 CI: Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ Signed-off-by: Martijn Stevenson <[email protected]>
johnlanni
suggested changes
Sep 10, 2024
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
42b6769 to
a47ab04
Compare
johnlanni
reviewed
Sep 10, 2024
johnlanni
reviewed
Sep 10, 2024
johnlanni
reviewed
Sep 10, 2024
mpwarres
pushed a commit
that referenced
this pull request
Sep 10, 2024
Seen on #380 CI: Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ Signed-off-by: Martijn Stevenson <[email protected]>
mpwarres
requested changes
Sep 10, 2024
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
Happy to merge this once @johnlanni 's open comments are addressed. Thanks!
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
a47ab04 to
2799342
Compare
- skip leading paddings in .aot section Signed-off-by: [email protected] <[email protected]>
lum1n0us
force-pushed
the
fr/padding_in_aot_section
branch
from
2799342 to
34c035c
Compare
mpwarres
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.