v8: add missing <cstdint> includes. #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary build fix until pr#382 lands. Signed-off-by: Martijn Stevenson <[email protected]>
martijneken
changed the title
Member
|
LGTM. Note that we usually concatenate all patches to |
Member
Ah, nevermind. I see it came from Envoy. |
PiotrSikora
changed the title
PiotrSikora
approved these changes
Jan 28, 2024
Contributor
Author
|
Looks like I can't merge it, please do the honors. |
Member
I don't have admin anymore, so I cannot override the other failing tests (macOS and cargo-raze). cc @mpwarres |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy changes from envoyproxy/envoy#29425.
This is a temporary build fix until #382 (major v8 upgrade, 10.7 -> 12.0).