chore: workflow runner fixes #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update format workflows to use ubuntu-22.04 - Enable manual triggering of workflows Fixes proxy-wasm#435 Signed-off-by: Michael Warres <[email protected]>
The windows-2019 runner image has been retired. Signed-off-by: Michael Warres <[email protected]>
leonm1
approved these changes
Jul 12, 2025
martijneken
approved these changes
Jul 12, 2025
This appears to be tripping up Windows builds: ``` ERROR: D:/a/proxy-wasm-cpp-host/proxy-wasm-cpp-host/BUILD:64:11: Compiling src/signature_util.cc failed: (Exit 2): cl.exe failed: error executing command (from target //:base_lib) C:\users\runneradmin\_bazel_runneradmin\dwxiuyix\execroot\proxy_wasm_cpp_host\include/proxy-wasm/signature_util.h(30): error C2039: 'string': is not a member of 'std' cd /d C:/users/runneradmin/_bazel_runneradmin/dwxiuyix/execroot/proxy_wasm_cpp_host ``` Signed-off-by: Michael Warres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435