Add test of NullVm. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
yxue
reviewed
Mar 25, 2020
yxue
left a comment
yxue
left a comment
There was a problem hiding this comment.
I am wondering if we can add some CI task for the repo.
wasm_vm_test.cc
Outdated
| TestNullVmPlugin *test_null_vm_plugin_ = nullptr; | ||
| RegisterNullVmPluginFactory register_test_null_vm_plugin("test_null_vm_plugin", []() { | ||
| auto plugin = std::make_unique<TestNullVmPlugin>(); | ||
| test_null_vm_plugin_ = plugin.get(); |
There was a problem hiding this comment.
We need to capture the variable in the lambda.
Contributor
Author
There was a problem hiding this comment.
We don't because it is a global. Do you think we should for style reasons?
There was a problem hiding this comment.
I think it's OK. Nit: renaming the variable to make it look like a global variable
Sorry, I didn't notice the |
yxue
reviewed
Mar 25, 2020
…to add-test Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
yxue
approved these changes
Mar 26, 2020
Signed-off-by: John Plevyak <[email protected]>
StarryVae
pushed a commit
to StarryVae/proxy-wasm-cpp-host
that referenced
this pull request
May 8, 2025
change sdk repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak [email protected]