Skip to content

Conversation

@110y
Copy link
Contributor

@110y 110y commented Mar 19, 2020

After #1 , now we should use PROXY_WASM_CPP_SDK instead DOCKER_SDK, right....?

Actually by following current README, we cannot build wasm file like below since Makefiles use PROXY_WASM_CPP_SDK :

> docker run -v $PWD:/work -w /work  wasmsdk:v2 /build_wasm.sh
Adding directories to PATH:
PATH += /root/emsdk
PATH += /root/emsdk/upstream/emscripten
PATH += /root/emsdk/node/12.9.1_64bit/bin

Setting environment variables:
EMSDK = /root/emsdk
EM_CONFIG = /root/.emscripten
EMSDK_NODE = /root/emsdk/node/12.9.1_64bit/bin/node

make: Nothing to be done for 'all'.

@110y 110y requested a review from jplevyak as a code owner March 19, 2020 11:11
@jplevyak jplevyak merged commit f8484b0 into proxy-wasm:master Mar 25, 2020
@110y 110y deleted the fix-readme branch March 26, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants