Apply playback factor on startup, pass Volume and recalculate ByteLimits #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few smaller fixes:
Regarding the TimedStream: There is still something wrong. It still doesn't make a difference what I set. I can't wrap my head around that... Is this code alright?:
https://github.com/pschatzmann/arduino-audio-tools/blob/70a927ff23fae2f0fece2da85b0a9ba51b15edf7/src/AudioTools/AudioIO.h#L277-L279
In case this returns false: Does whover writes to it actually keep the samples in buffer so we actually delay it? Or are the buffers dropped on 'false' and we start with the same data anyways?