CLOUD-1854-Fixing github issue #213 #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davejrt
suggested changes
Jun 18, 2018
spec/defines/system_user_spec.rb
Outdated
| context 'with default' do | ||
| let(:params) { {'create_user' => true} } | ||
| it { should contain_user('testuser') } | ||
| it { should contain_exec('docker-system-user-testuser').with_command(/docker testuser/) } | ||
| it { should contain_exec('docker-system-user-testuser').with_unless(/grep -qw testuser/) } | ||
| end | ||
|
|
||
| context 'when adding a system user' do |
There was a problem hiding this comment.
@MWilsonPuppet we don't need this test. The one you've added in the docker spec is sufficient. This one is failing because you're passing in a param that doesn't actually exist in the define type, not does the exec. A better place to test this would be in the service_spec.rb
| @@ -422,7 +422,6 @@ | |||
| it { should compile.with_all_deps } | |||
| it { should contain_class('docker::repos').that_comes_before('Class[docker::install]') } | |||
| it { should contain_class('docker::install').that_comes_before('Class[docker::config]') } | |||
| it { should contain_class('docker::service').that_subscribes_to('Class[docker::config]') } | |||
There was a problem hiding this comment.
Can we add in as part of this ensuring that the config class comes before the service class?
| @@ -28,7 +28,6 @@ | |||
| it { should contain_exec('install-docker-package').with_command("& #{service_install_file}") } | |||
| it { should contain_class('docker::repos').that_comes_before('Class[docker::install]') } | |||
| it { should contain_class('docker::install').that_comes_before('Class[docker::config]') } | |||
| it { should contain_class('docker::service').that_subscribes_to('Class[docker::config]') } | |||
There was a problem hiding this comment.
Can we add in as part of this ensuring that the config class comes before the service class?
MWilsonPuppet
force-pushed
the
CLOUD-1854-Fixing-restart-on-useradd
branch
from
d5d545c to
52a7d1a
Compare
MWilsonPuppet
changed the title
|
@davejrt Cheers for feedback. All changes have been made and unit and acceptance tests passing. |
davejrt
approved these changes
Jun 19, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #213 where the daemon was being restarted when a new user was added. Spec and acceptance tests have been added also.