Skip to content

Added support for awslogs #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

acurus-puppetmaster
Copy link
Contributor

AWSlogs which is AWS Cloudwatch logging support was not included, this is a standard log driver shipped with docker and as such should be supported.

Minimal changes have been made to the code to enable this support, essentially allowing awslogs for log_driver in init.pp.

The docker_spec.rb and docker_windows_spec.rb have also been updated, but no specific log_opts checks have been put in place for awslogs.

Sample usage is

docker::log_level: info
docker::log_driver: awslogs
docker::log_opt:
  - awslogs-region=ap-southeast-2
  - awslogs-group=%{facts.puppet_project}-%{facts.puppet_env}
  - awslogs-create-group=true
  - tag='%{facts.hostname}-{{.Name}}-{{.ID}}'

@acurus-puppetmaster
Copy link
Contributor Author

Any chance this can be merged?

@davejrt
Copy link
Contributor

davejrt commented Oct 25, 2018

LGTM

@davejrt davejrt merged commit aaf7458 into puppetlabs:master Oct 25, 2018
acurus-puppetmaster pushed a commit to acurus-puppetmaster/puppetlabs-docker that referenced this pull request Mar 18, 2019
davejrt pushed a commit that referenced this pull request Mar 18, 2019
* wip: updated README to include aws logging option details added in pull request #354

* wip: corrected formatting

* wip: corrected formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants