Skip to content

Add syslog_facility parameter to docker::run #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

waipeng
Copy link
Contributor

@waipeng waipeng commented Jun 11, 2021

It is useful to be able to control the facility of log messages, so that
it can be handled by syslog appropriately

@waipeng waipeng requested a review from a team as a code owner June 11, 2021 05:48
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

docker::run is a type

Breaking changes to this file WILL impact these 7 modules (exact match):
Breaking changes to this file MAY impact these 21 modules (near match):

This module is declared in 6 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

It is useful to be able to control the facility of log messages, so that
it can be handled by syslog appropriately
@waipeng
Copy link
Contributor Author

waipeng commented Jun 22, 2021

Hi, wondering if there's anything I need to get to get this merged?

@adrianiurca
Copy link
Contributor

Hey @waipeng, thank you for your contribution!

kind regards,
@adrianiurca

@adrianiurca adrianiurca merged commit ecc1d70 into puppetlabs:main Jun 22, 2021
@waipeng
Copy link
Contributor Author

waipeng commented Jun 22, 2021

Thanks @adrianiurca @kenyon @carabasdaniel for approving this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants