(MODULES-2634) Try / Catch Test Updates #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Iristyle
commented
May 26, 2016
•
Iristyle
commented
- Verify that we have actually executed a try / catch and exit with the expected status Paired-with: James Pogran <[email protected]>
- The tests introduced in 14e0be3 were insufficient at verifying that code inside of a try or catch block was actually being executed due to how the assertions were setup. Rewrite the tests to separately verify that code inside a try or a catch block will produce a file, whose contents can then be verified. Also assert that code we do not expect to be executed does not write files. Paired-with: James Pogran <[email protected]>
Iristyle
force-pushed
the
ticket/master/MODULES-2634-try-catch-tests-redux-again
branch
from
4dc5876 to
b401927
Compare
|
@puppetlabs/windows this is ready to go |
| @@ -29,7 +29,7 @@ | |||
| shell("/bin/touch #{default['puppetpath']}/hiera.yaml") | |||
| end | |||
| c.after :suite do | |||
| absent_files = 'file{["c:/services.txt","c:/process.txt"]: ensure => absent }' | |||
| absent_files = 'file{["c:/services.txt","c:/process.txt","c:/try_success.txt","c:/catch_shouldntexist.txt","c:/try_shouldntexist.txt","c:/catch_success.txt"]: ensure => absent }' | |||
There was a problem hiding this comment.
That's something I didn't realize - that it would not clean up those files by after each test.
|
Running this through adhoc now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.